Skip to content

bazel: Add rules for debian packaging#20235

Merged
phlax merged 2 commits intoenvoyproxy:mainfrom
phlax:dist-debian-bazel
Mar 10, 2022
Merged

bazel: Add rules for debian packaging#20235
phlax merged 2 commits intoenvoyproxy:mainfrom
phlax:dist-debian-bazel

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Mar 7, 2022

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:

breakout pr from #17979 containing only the bazel rules (and no ci changes)

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 7, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #20235 was opened by phlax.

see: more, trace.

@phlax phlax assigned lizan and unassigned moderation Mar 7, 2022
@phlax phlax requested a review from lizan March 7, 2022 11:23
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Mar 7, 2022

@lizan i have broken the bazel parts out from the #17979 pr

it would be really good to land this soon

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the dist-debian-bazel branch from 000fab5 to 65704c8 Compare March 7, 2022 11:28
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great, just one nit.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax merged commit f19807e into envoyproxy:main Mar 10, 2022
JuniorHsu pushed a commit to JuniorHsu/envoy that referenced this pull request Mar 17, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants